[Docs] reemove the incorrect enable_reasoning parameter
#27550
Conversation
Signed-off-by: zxw <1020938856@qq.com>
|
Documentation preview: https://vllm--27550.org.readthedocs.build/en/27550/ |
mergify
bot
added
documentation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly removes the --enable_reasoning parameter from the documentation, as it is not a valid vLLM CLI argument. The change is accurate and improves the documentation.
While reviewing, I discovered a critical bug in the HunyuanA13BReasoningParser that prevents the enable_thinking: false feature from working as intended. The is_reasoning_end method does not correctly process prompt tokens, leading to incorrect behavior when reasoning is disabled via request parameters. I've added a comment with a suggested fix for this issue.
Also, a minor note: the pull request title has a typo ("reemove" instead of "remove").
Overall, the documentation change is good to merge, but I highly recommend addressing the identified bug to ensure the Hunyuan model's reasoning features work correctly.
chaunceyjiang
left a comment
chaunceyjiang
left a comment
There was a problem hiding this comment.
--enable_reasoning is deprecated.
ref #17452
…ct#27550) Signed-off-by: zxw <1020938856@qq.com>
…ct#27550) Signed-off-by: zxw <1020938856@qq.com>
…ct#27550) Signed-off-by: zxw <1020938856@qq.com>
…ct#27550) Signed-off-by: zxw <1020938856@qq.com>
4 participants
Purpose
vLLM does not have
enable_reasoningparameterTest Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.